Add rule for Busybox GPL-2.0-or-later notice (#4969) - #5302
Open
Shubha3121 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Shubha3121 <ammushubha2006@gmail.com>
Shubha3121
force-pushed
the
fix-gpl-false-positive-4969
branch
from
September 10, 2026 00:38
2609dbf to
502c873
Compare
Shriprasad-P
left a comment
Shriprasad-P
left a comment
There was a problem hiding this comment.
Review
PR: Add rule for Busybox GPL-2.0-or-later notice (#4969)
Touched: src/licensedcode/data/rules/gpl-2.0-plus_1156.RULE
- Addresses a concrete correctness/reliability issue based on the title and diff.
- Size looks manageable (+10/-0).
Commenting as a drive-by reviewer after reading the diff. Happy to look again if maintainers want a deeper pass on a specific file.
Author
|
@Shriprasad-P "Thanks for taking a look and reviewing!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4969
Description
Added rule
gpl-2.0-plus_1156.RULEfor the Busybox notice:Previously, this notice was matched by
gpl-2.0_470.RULEasgpl-2.0(GPL-2.0-only) with a 92.0 score via sequence matching. With the addition ofgpl-2.0-plus_1156.RULE, it resolves togpl-2.0-plus(GPL-2.0-or-later) with an exact 100.0 score via the1-hashmatcher.Tasks